Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17267 )
Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17267/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17267/2/src/kudu/tools/tool_action_master.cc@349 PS2, Line 349: // Get the flags that'll be needed to bring up new master and for system catalog copy. : GFlagsMap flags_map = GetFlagsMap(); > Because "--flag_a val_a" is a valid way to pass a gflag and we'll have to > restrict users from doing so in this case. That's true, but I think it's reasonable to define the structure of a --master_flags="--foo=bar" as we please, and expect users to follow it. Especially if one of the main usages here will be a script that can generate it in that form anyway. I guess I'm arguing from the side that this flag will have very few users, and the one user that we're sure about doesn't have this problem. http://gerrit.cloudera.org:8080/#/c/17267/2/src/kudu/tools/tool_action_master.cc@363 PS2, Line 363: [[maybe_unused]] > Helped quiesce unused variable warning with _ on my machine. But I see it d Ah, looks like I was wrong, and it is being assigned a name: "_". -- To view, visit http://gerrit.cloudera.org:8080/17267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f99cf2b3f1738c4127c7e7288beab61daf42e7b Gerrit-Change-Number: 17267 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Apr 2021 20:33:26 +0000 Gerrit-HasComments: Yes
