[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18174 )
Change subject: Adding repartitioning logic along with coalesce logic to backup output ...................................................................... Patch Set 5: (3 comments) Thank you for the review. Working on addressing the comments http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG@7 PS4, Line 7: Adding repartitioning logic along with coalesce logic to backup output > As it's a new feature, I think it would be useful to have a JIRA created fo Thanks for the review, I had created a Jira, added it to the description http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG@10 PS4, Line 10: > This part doesn't seem useful in the commit message once it's merged. Maybe Ack http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG@17 PS4, Line 17: Coalesce takes precedence over repartition if both of them are defined. > Can you add a test instead? Ack -- To view, visit http://gerrit.cloudera.org:8080/18174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I328cb7e41bca14b7b6d73eb7721a86fb86203201 Gerrit-Change-Number: 18174 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Feb 2022 04:49:38 +0000 Gerrit-HasComments: Yes
