[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18174 )
Change subject: Adding repartitioning logic along with coalesce logic to backup output ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG@10 PS4, Line 10: > Ack I have modified to description to add details about the coalesce and repartition options http://gerrit.cloudera.org:8080/#/c/18174/4//COMMIT_MSG@17 PS4, Line 17: > Ack Added assert in existing tests with the new options. http://gerrit.cloudera.org:8080/#/c/18174/4/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/18174/4/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@95 PS4, Line 95: // Coalesce takes precedence over repartition. > Maybe it should fail, or at least emit a warning if both are specified? I think a warning would be good, added a warning if both coalesce and repartition are specified http://gerrit.cloudera.org:8080/#/c/18174/4/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala: http://gerrit.cloudera.org:8080/#/c/18174/4/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala@174 PS4, Line 174: .text("Sets the repartition output. Maximum number of output. Default: " + DefaultRepartitionOutput) > nit: line too long Fixed -- To view, visit http://gerrit.cloudera.org:8080/18174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I328cb7e41bca14b7b6d73eb7721a86fb86203201 Gerrit-Change-Number: 18174 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Feb 2022 05:56:21 +0000 Gerrit-HasComments: Yes
