Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc@250 PS1, Line 250: !op->result->has_failed_status() nit: maybe put this in an else block to avoid the negative? -- To view, visit http://gerrit.cloudera.org:8080/18281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812 Gerrit-Change-Number: 18281 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 28 Feb 2022 23:43:15 +0000 Gerrit-HasComments: Yes
