Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors ...................................................................... [tablet] don't call UpdateMetricsForOp() for rows with errors This patch updates the control path in WriteOp::UpdatePerRowErrors() to avoid calling UpdateMetricsForOp() for a row that contains an error since that's effectively a no-op. Also, renamed UpdatePerRowErrors() into UpdatePerRowMetricsAndErrors(). Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812 Reviewed-on: http://gerrit.cloudera.org:8080/18281 Tested-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h 2 files changed, 15 insertions(+), 13 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812 Gerrit-Change-Number: 18281 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)
