Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127 PS3, Line 127: void DoTestServerDisconnects(bool accept, const std::string &message) { > I guess eventually we want to use std::thread everywhere in Kudu code, so I Done http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@136 PS3, Line 136: CHECK_OK(listener_.Accept(&sock, &new_addr > What's the reason to have this extra wait interval? Please add a comment t Removed -- To view, visit http://gerrit.cloudera.org:8080/18431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33 Gerrit-Change-Number: 18431 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 26 Apr 2022 10:00:04 +0000 Gerrit-HasComments: Yes
