Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Thank you for the fix! The current approach is much better than the prior one which relied on some timing (that might be still a bit flaky due to various scheduling anomalies). http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127 PS3, Line 127: void DoTestServerDisconnects(bool accept, const std::string &message) { > Done OK, it seems I made a typo (would -- would not): I meant using std::thread is totally fine in here. I apologize for the mis-typing. Anyways, since you have already did the change, that's totally fine -- using kudu::Thread is also a way to go. -- To view, visit http://gerrit.cloudera.org:8080/18431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33 Gerrit-Change-Number: 18431 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 26 Apr 2022 16:50:22 +0000 Gerrit-HasComments: Yes
