Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 )
Change subject: [client] fix toggling fault-tolerance for a scanner ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::ReadMode::READ_LATEST, sc.read_mode()); > This seems a bit surprising -- why not have SetFaultTolerant(false) leave t The idea was to return it back to the original state that ScanConfiguration was created with. I agree there might be different idea how it works: the current API is a bit clumsy for fault tolerance settings. -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 02:02:18 +0000 Gerrit-HasComments: Yes
