Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 )
Change subject: [client] fix toggling fault-tolerance for a scanner ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::READ_AT_SNAPSHOT, sc.read_mode()); > It turns out the code in Java client assumes that switching to non-fault-to Right, I might expect that kind of behavior in some ResetToDefault() call or somesuch, but it seemed a bit odd otherwise. Things like scanner.SetReadMode(READ_AT_SNAPSHOT); scanner.SetFaultTolerant(false); would be have surprising results in that case IMO -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 05:14:30 +0000 Gerrit-HasComments: Yes
