Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17555 )
Change subject: [rest] add rest implementation ...................................................................... Patch Set 51: (2 comments) http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/integration-tests/rest_server-itest.cc File src/kudu/integration-tests/rest_server-itest.cc: http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/integration-tests/rest_server-itest.cc@84 PS50, Line 84: vector<string> ParseResponse(const std::vector<std::string>& response) { > Yes, Oat++ has its own serialised/deserializer, it works with Data Transfer Still, it would be cleaner to use a real JSON parser. http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/rest/rest_server.cc File src/kudu/rest/rest_server.cc: http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/rest/rest_server.cc@74 PS50, Line 74: .setVersion("1.15.0") > Yes, this should be the same as the Kudu Version, there is no way to update Can't you use VersionInfo? -- To view, visit http://gerrit.cloudera.org:8080/17555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ca3121fd7e95a1267853be45cb5f5855298c763 Gerrit-Change-Number: 17555 Gerrit-PatchSet: 51 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 26 May 2022 10:28:47 +0000 Gerrit-HasComments: Yes
