Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17555 )

Change subject: [rest] add rest implementation
......................................................................


Patch Set 52:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/integration-tests/rest_server-itest.cc
File src/kudu/integration-tests/rest_server-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17555/50/src/kudu/integration-tests/rest_server-itest.cc@84
PS50, Line 84: vector<string> ParseResponse(const std::vector<std::string>& 
response) {
> Will give it a look, main reason I have avoided using it for writing/parsin
EasyJson is a wrapper around rapidjson for easier json obj building, so it 
should be completely fine to use rapidjson separately in this instance to parse 
json strings.
Alternatively you could extend EasyJson with parsing capabilities.



--
To view, visit http://gerrit.cloudera.org:8080/17555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca3121fd7e95a1267853be45cb5f5855298c763
Gerrit-Change-Number: 17555
Gerrit-PatchSet: 52
Gerrit-Owner: Khazar Mammadli <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Khazar Mammadli <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 26 May 2022 14:41:51 +0000
Gerrit-HasComments: Yes

Reply via email to