Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19158 )
Change subject: [rpc] avoid crashes on malicious negotiation attempts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19158/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/19158/1/src/kudu/rpc/client_negotiation.h@39 PS1, Line 39: #include "kudu/security/token.pb.h" > Maybe removing 'class SignedTokenPB;' will trigger IWYU to check this file. Yes, Yingchun is right: IWYU pointed that this include is needed, so I just followed the recommendation. -- To view, visit http://gerrit.cloudera.org:8080/19158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I416e3e952a3ee928ed6c51389227184c73a96b0b Gerrit-Change-Number: 19158 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 22 Oct 2022 15:56:32 +0000 Gerrit-HasComments: Yes
