Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19158 )
Change subject: [rpc] avoid crashes on malicious negotiation attempts ...................................................................... [rpc] avoid crashes on malicious negotiation attempts This patch updates the code for RPC connection negotiation to change from CHECK() to LOG(DFATAL) and Status::IllegalState() when checking on some security constraint. This narrows the attack vector of potential DOS attacks for Kudu servers. Change-Id: I416e3e952a3ee928ed6c51389227184c73a96b0b Reviewed-on: http://gerrit.cloudera.org:8080/19158 Tested-by: Kudu Jenkins Reviewed-by: Yuqi Du <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/rpc/client_negotiation.cc M src/kudu/rpc/client_negotiation.h M src/kudu/rpc/server_negotiation.cc 3 files changed, 31 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Yuqi Du: Looks good to me, but someone else must approve Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I416e3e952a3ee928ed6c51389227184c73a96b0b Gerrit-Change-Number: 19158 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
