Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica edit delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19357/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19357/1//COMMIT_MSG@7 PS1, Line 7: edit nit: How about renaming it to 'edit_metadata'? http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tablet/tablet_metadata.cc@71 PS1, Line 71: only rowset ids are removed from " : "tablet metadata, the related blocks are kept on file system. You " : "can start the server to check whether the operation is worked as " : "expect, if it is, then shutdown the server and run 'kudu fs check " : "--repair=true' to remove orphaned blocks, or use the backup " : "tablet-metadata to roll back. I'm curious about the scene where we need to keep blocks in this way. From my understanding, is it enough to use the backup flag? http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tools/kudu-tool-test.cc@8812 PS1, Line 8812: ASSERT_EQ(rowset_ids.size() - 1, new_rowset_ids.size()); nit: Should we also check that new_rowset_ids do not contain the id of deleted rowset? -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 15 Dec 2022 10:16:46 +0000 Gerrit-HasComments: Yes
