Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica edit_metadata delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG@7 PS3, Line 7: edit_metadata what about 'edit_tmeta' http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tablet/tablet_metadata.cc@76 PS3, Line 76: "tablet-metadata to roll back. Note: This is only used for CLI " It seems a little complex. How to use the tool an the series operations, it's better write these into docs in the future http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc@105 PS3, Line 105: DEFINE_bool(backup_metadata, false, It's safer using default 'true' and use 'enable_adding_orphaned_blocks' false ? The tool's aim is setting the two flags FLAGS_backup_metadata false and FLAGS_enable_adding_orphaned_blocks true, the setting is convenient for the fault case, isn't it? http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc@1250 PS3, Line 1250: ModeBuilder("edit_matadata") What about renaming ’metadata‘ to 'tmeta' -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 20 Dec 2022 12:28:59 +0000 Gerrit-HasComments: Yes
