KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )
Change subject: [log] Reduce prompt log printing frequency ...................................................................... Patch Set 6: (5 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@9 PS5, Line 9: UpdateStats() function print too frequently > But that's only in case of disabling particular type of compaction, isn't i Yes, you're right and I will add this supplement. http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@10 PS5, Line 10: soft-delete > What is 'trash table'? Sorry, I meant the soft-deleted table. http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92 PS5, Line 92: 600 > Maybe, make it something to be round in the number of minutes? If you don' Done http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@94 PS5, Line 94: TAG_FLAG(update_stats_print_prompt_log_interval_s, runtime); > I guess it make makes sense adding the 'experimental' tag as well. Done http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@380 PS5, Line 380: f (PREDICT_FALSE(!FLAGS_enable_u > Don't you want to update this to be configurable as well? Done -- To view, visit http://gerrit.cloudera.org:8080/19375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 20 Dec 2022 02:01:38 +0000 Gerrit-HasComments: Yes
