Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )
Change subject: [log] Reduce prompt log printing frequency ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@9 PS7, Line 9: print prints http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10 PS7, Line 10: compaction Could you be more specific here: what type of compaction was disabled? http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10 PS7, Line 10: disable disabled http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@12 PS7, Line 12: the problem better What problem are we talking about here? http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc@93 PS7, Line 93: prompt I'm not sure I understand what you meant by 'prompt' here. From what I can see in this patch, I'd think of the following description for this flag: Log throttling interval for messages on disabled compaction emitted by UpdateStats method. -- To view, visit http://gerrit.cloudera.org:8080/19375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 7 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 20 Dec 2022 06:36:11 +0000 Gerrit-HasComments: Yes
