Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] Return immediately after the limit number of rows have been dumped ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19369/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19369/5//COMMIT_MSG@7 PS5, Line 7: Return > Use upper case? Done http://gerrit.cloudera.org:8080/#/c/19369/5/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/19369/5/src/kudu/tablet/memrowset.cc@151 PS5, Line 151: Status MemRowSet::DebugDumpImpl(int64_t* rows_left, vector<string>* lines) { > How about defining 2 functions: Tha sounds a good idea, done. -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Fri, 13 Jan 2023 08:21:26 +0000 Gerrit-HasComments: Yes
