Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] Return immediately after the limit number of rows have been dumped ...................................................................... Patch Set 6: Code-Review+1 (6 comments) A few nits left to fix, otherwise looks good to me. http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h@180 PS6, Line 180: // If 'rows_left' is nullptr, there is no limit on the number of rows to dump. : // If the content of 'rows_left' equal to or less than 0, no rows will be dumped. It seems this part is not relevant for this function anymore. Probably, the whole doc for this function now needs to be moved to line 313? And this comment updated, removing this irrelevant part? http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc File src/kudu/tablet/rowset.cc: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc@53 PS6, Line 53: style nit: the indent here should be 2 spaces, not 4 http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1037 PS6, Line 1037: No matter if there are any rows to be printed, the metadata will be printed. When the --dump_metadata flag is set to 'true', the metadata is always printed regardless of the number of rows to print. http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1091 PS6, Line 1091: It's not needed to read the next block when reach rows limit How about: There is no need to read the next block when the row limit has been reached. http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097 PS6, Line 1097: larger nit: greater http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097 PS6, Line 1097: will always been : // printed in pairs. ... are always printed in pairs -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 07:04:27 +0000 Gerrit-HasComments: Yes
