Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 2: Code-Review+1 > Patch Set 2: Verified+1 Code-Review+1 > > LGTM, but I'm curious what's use case of it, this flag seems only useful in > tests. Yes. You are right. I also think that this patch is not important, the scenarios of using it may be rare, only some special scenarios should change the flag for administrators. But the purpose of provided the this flag, it should support change it. So I decide to submit this patch. -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 2 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 07:28:35 +0000 Gerrit-HasComments: No
