Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 2: -Code-Review (4 comments) > Patch Set 2: > > (4 comments) I have fixed them according to your advices. Thanks a lot. http://gerrit.cloudera.org:8080/#/c/19398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19398/1//COMMIT_MSG@10 PS1, Line 10: But : restart tserver sometimes very slow. > I understand. So, this change is just to add support to change FLAGS_enable Yes, you are right. http://gerrit.cloudera.org:8080/#/c/19398/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19398/2//COMMIT_MSG@11 PS2, Line 11: tserver sometimes very slow > nit: How about this. - "of a tablet server can sometimes be quite time cons Done http://gerrit.cloudera.org:8080/#/c/19398/2//COMMIT_MSG@13 PS2, Line 13: This patch support change FLAGS_enable_maintenance_manager at runtime, it : can avoid troublesome restart operation when administrators need do this. > How about - Done http://gerrit.cloudera.org:8080/#/c/19398/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19398/2/src/kudu/util/maintenance_manager.cc@312 PS2, Line 312: if (shutdown_) { : return; : } > shutdown_ check seems to be already present on line num 336 below. What Yifan said, that's ok. I change it. As Ashwanl said, L336 is not enough, because when FLAGS_enable_maintenance_manager is false, the thread 'RunSchedulerThread()' may not stop when shutdown. The idea that moving L336 the beginning of 'while (true)', I think that's ok. -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 2 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 03:57:57 +0000 Gerrit-HasComments: Yes
