Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h@1180 PS2, Line 1180: const std::string& table_id() const; : const std::string& table_name() const; Expose functions to user client should be very carefully, we have to maintenace the user APIs for long time supporting. If the function is only used in CLI tools, you can use KuduTablet::Data directly. http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto@449 PS2, Line 449: optional string table_name = 9; If we want to use the feature we have to upgrade the servers, can we gather the table name from other existing methods? http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@292 PS2, Line 292: cout << Substitute("Table id: $0, Table name: $1", : tablet->table_id(), tablet->table_name()) << endl; : DataTable cmatrix({ "UUID", "Host", "Port", "Is Leader"}); The outputs are in two sections and in different format. If we only need the replica location output in JSON format and parsed by a 3rd party tool, how can we achieve that? Maybe control the output sections by another flag? http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@300 PS2, Line 300: ostream out(std::cout.rdbuf()); : return cmatrix.PrintTo(out); nit: return cmatrix.PrintTo(cout); ? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 21 Feb 2023 15:25:34 +0000 Gerrit-HasComments: Yes
