Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h@1180 PS2, Line 1180: const std::string& table_id() const; : const std::string& table_name() const; > Expose functions to user client should be very carefully, we have to mainte KuduTablet::Data is private to CLI tools. Friendly class seems to be no suitable also. A similar data structure: TabletInfo defined in catalog_manager.h also contains the information of table. KuduTablet contains table_id, table_name may be ok. http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto@449 PS2, Line 449: optional string table_name = 9; > If we want to use the feature we have to upgrade the servers, can we gather Currently no suitable functions found to get the table info according tablet id. http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@300 PS2, Line 300: for (const auto& replica : tablet->replicas()) { : TabletInfoPB::LocationIn > nit: return cmatrix.PrintTo(cout); ? The out parameter of PrintTo() is ostream -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 24 Feb 2023 06:42:17 +0000 Gerrit-HasComments: Yes
