Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 7: Code-Review+1 (4 comments) Overall looks good, just a few nits http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG@17 PS7, Line 17: follow following http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc@6276 PS7, Line 6276: locs_pb->mutable_table_info()->CopyFrom(table_info_pb); nit: you could use std::move() here to prevent copying: *locs_pb->mutable_table_info() = std::move(table_info_pb); Alternatively, it could be: auto* info = locs_pb->mutable_table_info(); info->set_id(tablet_info->table()->id()); info->set_name(tablet_info->table()->table_name()); http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@126 PS7, Line 126: UUID nit: Tablet Server UUID http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@414 PS7, Line 414: Show the table and location information of a tablet. nit: maybe change this to be more specific Show information on the table which the tablet is a part of and where tablet replicas are located. -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Sun, 19 Mar 2023 17:42:46 +0000 Gerrit-HasComments: Yes
