Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@298 PS9, Line 298: Status KuduClient::Data::GetTablet(KuduClient* client, > I'm not clear why to move this function from KuduClient to KuduClient::Data Just to keep the same style. Client.cc exposes the interface to the user, and client-internal.cc implements the interface. Please see the following function: GetTabletServer() http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@301 PS9, Line 301: const > At least, it can be static (in L307, use client->default_admin_operation_ti Done L307. http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h@797 PS9, Line 797: get_extra_info > Could you plz add some comments to describe what dose 'get_extra_info' mean Done http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc@6241 PS9, Line 6241: R > nit: indent Done http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@109 PS9, Line 109: if (FLAGS_json) { > DataTable is support to output in JSON format(see DataTable::PrintTo), why Done http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@124 PS9, Line 124: cout << Substitute("Table id: $0, Table name: $1", > So if --json is enabled, table id and name will not be output? To simply the code, I will output table id and table name for every replica. Maybe the data has some duplication, but it does matter. The following is an example: pretty format: Table Id | Table Name | Tablet Server UUID | Host | Port | Is Leader ----------------------------------+------------+----------------------------------+---------------+-------+----------- 883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 5116514e00024a71926c722f5ccfaf44 | 127.42.53.193 | 41263 | false 883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 7041740e966d45d38be3cc6c79c1f67f | 127.42.53.194 | 35579 | true 883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 4c4d43e7e0bc4d41b23f072ad2dfe85d | 127.42.53.195 | 40701 | false json format: [{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"909a581760ae40ceb8837d72cc989ede","Host":"127.45.86.65","Port":"44353","Is Leader":"true"},{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"b509cc1057af4dda9cc596c7f87849a1","Host":"127.45.86.66","Port":"42719","Is Leader":"false"},{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"9413e042a42549409367c722a50785e4","Host":"127.45.86.67","Port":"36483","Is Leader":"false"}] -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 23 Mar 2023 12:04:03 +0000 Gerrit-HasComments: Yes
