Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19650 )
Change subject: [rowset_metadata] add min/max encoded keys update during restart ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/19650/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19650/2//COMMIT_MSG@7 PS2, Line 7: add min/max encoded keys update during restart What about "update min/max encoded keys during bootstrapping" http://gerrit.cloudera.org:8080/#/c/19650/2//COMMIT_MSG@10 PS2, Line 10: bootstrap tablets tablets to bootstrap http://gerrit.cloudera.org:8080/#/c/19650/2//COMMIT_MSG@21 PS2, Line 21: ensures nit: ensure http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/cfile_set.h@152 PS2, Line 152: return min_encoded_key_; friend method 'TestSetEncodedKeysWhenStartup' can access the variables 'min_encoded_key_' and 'max_encoded_key_'? http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/diskrowset.h@512 PS2, Line 512: base_data_ Could firend method ' FRIEND_TEST(tserver::TabletServerTest, TestSetEncodedKeysWhenStartup); ' access 'base_data_' ? http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tserver/tablet_server-test.cc@4636 PS2, Line 4636: min_key The two output parameters 'min_key' and 'max_key' seem not used, they are checked in the lambda function. So remove them into the internal of 'restart_server_and_check_encoded_key'? -- To view, visit http://gerrit.cloudera.org:8080/19650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7ed75bdf7a2ff0e16c2670f1a6f9819ee8e8d3 Gerrit-Change-Number: 19650 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Mon, 27 Mar 2023 06:57:18 +0000 Gerrit-HasComments: Yes
