KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19650 )
Change subject: [rowset_metadata] update min/max encoded keys during bootstrapping ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19650/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19650/4//COMMIT_MSG@9 PS4, Line 9: We can cache the encoded min/max keys in rowset metadata to help : tablets to bootstrap without having to fully initializing the CFileReaders : for the key columns of each rowset. > Is there any bug you encountered if not updating min/max key in metadata? I found a missing min/max key when locating an older kudu version of the data release issue, and there is no way to update it. This may affect the metadata update after the delta data is compressed, and the complete root cause is still being confirmed. Regardless of the debug for this issue, this patch will be helpful for accelerating the startup of older kudu versions. http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: http://gerrit.cloudera.org:8080/#/c/19650/2/src/kudu/tablet/cfile_set.h@150 PS2, Line 150: Status NewColumnIterator(ColumnId col_id, > The functions are more or less similar to public get()/set() member functio Thank you for your correction. I will remove this part of the code. http://gerrit.cloudera.org:8080/#/c/19650/4/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/19650/4/src/kudu/tablet/cfile_set.cc@213 PS4, Line 213: RETURN_NOT_OK(key_index_reader()->Init(io_context)); > The function name is 'LoadMinMaxKeys' which means only update member min/ma Good idea. Thanks for your advice. -- To view, visit http://gerrit.cloudera.org:8080/19650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7ed75bdf7a2ff0e16c2670f1a6f9819ee8e8d3 Gerrit-Change-Number: 19650 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 28 Mar 2023 03:01:17 +0000 Gerrit-HasComments: Yes
