KeDeng has uploaded this change for review. (
http://gerrit.cloudera.org:8080/19871
Change subject: [tests] fix flakiness in TestLogCleanupOnStartup
......................................................................
[tests] fix flakiness in TestLogCleanupOnStartup
I noticed the TestLogCleanupOnStartup scenario of the LogRollingITest
was a bit flaky. This case is used to confirm whether the periodic
deletion of the limited number of log files is effective.
However, considering that the previous scheduling cycle was 60 seconds,
we usually cannot wait until the next scheduling, which can cause the
unit test case to fail as follows:
`
COULD NOT CREATE A LOGGINGFILE 20230510-110713.1877!I20230510 11:07:14.550666
1226 external_mini_cluster.cc:1362] Started
/data/github-kudu/tmp-review/kudu/build/release/bin/kudu as pid 1877
/data/github-kudu/tmp-review/kudu/src/kudu/integration-tests/log-rolling-itest.cc:82:
Failure
Expected equality of these values:
std::min(3, i)
Which is: 3
CountInfoLogs(cluster.master()->log_dir())
Which is: 4
/data/github-kudu/tmp-review/kudu/src/kudu/util/test_util.cc:392: Failure
Failed
Timed out waiting for assertion to pass.
`
I have added a new flag '--excess_log_file_deleter_execute_interval_secs'
to facilitate the control of the scheduling cycle, so that we can ensure
that the deletion operation is scheduled during testing.
Change-Id: I6ee02316fb0850a52251f3740309213b69ca79b8
---
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/server/server_base.cc
2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/19871/1
--
To view, visit http://gerrit.cloudera.org:8080/19871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee02316fb0850a52251f3740309213b69ca79b8
Gerrit-Change-Number: 19871
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kdeng...@gmail.com>
