Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19871 )
Change subject: [tests] fix flakiness in TestLogCleanupOnStartup ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19871/1/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: http://gerrit.cloudera.org:8080/#/c/19871/1/src/kudu/integration-tests/log-rolling-itest.cc@85 PS1, Line 85: SleepFor(MonoDelta::FromSeconds(3)); This will cause this unit test case consume 3 seconds at least, the ASSERT_EVENTUALLY will retry with some time intervals itself, so I guess we can remove this sleep, right? -- To view, visit http://gerrit.cloudera.org:8080/19871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ee02316fb0850a52251f3740309213b69ca79b8 Gerrit-Change-Number: 19871 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 17 May 2023 05:09:19 +0000 Gerrit-HasComments: Yes
