Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19873 )
Change subject: KUDU-3448 Move password retrieval to master init ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19873/4/src/kudu/security/token_signing_key.h File src/kudu/security/token_signing_key.h: http://gerrit.cloudera.org:8080/#/c/19873/4/src/kudu/security/token_signing_key.h@72 PS4, Line 72: std::unique_ptr<PrivateKey> > Consider making this the last parameters, the same as in the other construc Done -- To view, visit http://gerrit.cloudera.org:8080/19873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746e657ae8d295f5f34225d63686beea1dff6b7c Gerrit-Change-Number: 19873 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Wed, 31 May 2023 07:37:36 +0000 Gerrit-HasComments: Yes