Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19873 )
Change subject: KUDU-3448 Move password retrieval to master init ...................................................................... Patch Set 6: > > > Patch Set 5: > > > > > > (1 comment) > > > > Not sure if we follow this suggestion as it works fine with > C++17, > > but errors in C++20. We are following tidy suggestions anyway, > > right? > > What was that? I think items related to C++20 should be taken care of in a separate scope. Yes, it would be great to add the 'explicit' keyword to the constructor accepting a single parameter, but it's considered to be a minor issue/nit if not having that. We have a few other places where that could be improved. So, I think this changelist is good to go. -- To view, visit http://gerrit.cloudera.org:8080/19873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746e657ae8d295f5f34225d63686beea1dff6b7c Gerrit-Change-Number: 19873 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Jun 2023 18:00:37 +0000 Gerrit-HasComments: No
