Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 )
Change subject: [client] KUDU-1945 Add upsert support ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG Commit Message: PS2: > I think at least one piece is missing in this patch: client-side verificati Added http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG@7 PS2, Line 7: upsert > nit: UPSERT Done http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG@9 PS2, Line 9: upsert > UPSERT Done http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG@9 PS2, Line 9: c++ > C++ Done http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG@10 PS2, Line 10: previoulsy > typo? Done http://gerrit.cloudera.org:8080/#/c/20083/2//COMMIT_MSG@10 PS2, Line 10: upsert > UPSERT Done http://gerrit.cloudera.org:8080/#/c/20083/1/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/20083/1/src/kudu/common/schema.cc@314 PS1, Line 314: key_columns > It would be great to add a comment to clarify why key_columns is essential This change makes sense to be a part of the next patch (https://gerrit.cloudera.org/#/c/20084/). Will push it there and address the comment. -- To view, visit http://gerrit.cloudera.org:8080/20083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Gerrit-Change-Number: 20083 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Wed, 21 Jun 2023 21:39:49 +0000 Gerrit-HasComments: Yes
