Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 )
Change subject: [client] KUDU-1945 Add UPSERT support ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20083/7/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/20083/7/python/kudu/tests/test_client.py@489 PS7, Line 489: op = table.new_upsert() > Add a test sub-case for UPSERT_IGNORE as well? UPSERT_IGNORE is not added to the Python client yet. (https://github.com/apache/kudu/blob/master/python/kudu/libkudu_client.pxd#L684-L690). Could you please add a TODO to check for UPSERT_IGNORE, once it is implemented in the Python client? -- To view, visit http://gerrit.cloudera.org:8080/20083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Gerrit-Change-Number: 20083 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 19:13:37 +0000 Gerrit-HasComments: Yes
