Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 )
Change subject: KUDU-3448 Add support for encrypting existing keys ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/20050/9//COMMIT_MSG Commit Message: PS9: > Is it possible to add a new test scenario to verify that switching from non Done http://gerrit.cloudera.org:8080/#/c/20050/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20050/9/src/kudu/master/catalog_manager.cc@1363 PS9, Line 1363: LOG(INF > Since that's going to be just a single run when this happens, maybe change Done http://gerrit.cloudera.org:8080/#/c/20050/9/src/kudu/master/catalog_manager.cc@1373 PS9, Line 1373: LOG(INF > ditto Done http://gerrit.cloudera.org:8080/#/c/20050/9/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: http://gerrit.cloudera.org:8080/#/c/20050/9/src/kudu/master/sys_catalog.h@271 PS9, Line 271: > nit: in Done -- To view, visit http://gerrit.cloudera.org:8080/20050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide6ec4fb86325897f2b011aee9643d276044279d Gerrit-Change-Number: 20050 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 11:47:06 +0000 Gerrit-HasComments: Yes
