Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 )
Change subject: KUDU-3448 Add support for encrypting existing keys ...................................................................... Patch Set 10: (4 comments) overall looks good to me, just a few nits and it seems IWYU isn't yet happy: 04:11:30 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/master/sys_catalog.h' 04:11:30 @@ -26,6 +26,7 @@ 04:11:30 04:11:30 #include <gtest/gtest_prod.h> 04:11:30 04:11:30 +#include "kudu/common/row_operations.pb.h" 04:11:30 #include "kudu/common/schema.h" 04:11:30 #include "kudu/consensus/metadata.pb.h" 04:11:30 #include "kudu/gutil/macros.h" 04:11:30 IWYU would have edited 1 files on your behalf. http://gerrit.cloudera.org:8080/#/c/20050/9//COMMIT_MSG Commit Message: PS9: > Done Thanks a lot! http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1161 PS10, Line 1161: ASSERT_OK(StartCluster()); nit: does it make sense to add SKIP_IF_SLOW_NOT_ALLOWED() here since this scenario is supposed to hit timeout as well? http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1166 PS10, Line 1166: SmokeTestCluster nit for here and below for SmokeTestCluster() call sites: does it make sense to wrap this into NO_FATALS() to bail out right away if anything fails? http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1179 PS10, Line 1179: cluster_->Shutdown(); : ASSERT_TRUE(cluster_->Restart().IsTimedOut()); nit: it would be great to have a small comment to explain why timeout is expected on shutting down the cluster -- it's not quite obvious why the flags would be affect shutting down (say, I'd not expect the keys to be loaded when a cluster is being shut down?) -- To view, visit http://gerrit.cloudera.org:8080/20050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide6ec4fb86325897f2b011aee9643d276044279d Gerrit-Change-Number: 20050 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 19:40:58 +0000 Gerrit-HasComments: Yes
