Hello Marton Greber, Zoltan Chovan, Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/20651

to review the following change.


Change subject: KUDU-3522 Fail early when encryption init fails
......................................................................

KUDU-3522 Fail early when encryption init fails

If encryption is enabled using --encrypt_data_at_rest, but the file
system was formatted without encryption enabled, Kudu would be unable to
bootstrap tablets as the encryption headers are missing, however, it
would still start happily without being able to host any tablets.

In some cases, for example when attempting to rebalance a cluster which
contain such "zombie" tablet servers, it can cause some cryptic error
message such as this:

Failed to initialize encryption: error:0607B083:digital envelope 
routines:EVP_CipherInit_ex:no cipher set

This commit adds a check to the FS manager to disallow starting up with
encryption enabled and existing instance files without server keys to
address this issue as it's better to fail early in this case. It also
adds a regression test to verify it works as expected.

Change-Id: I7721953869452197f537b161bd6c6b095cc7e75f
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 26 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/20651/1
--
To view, visit http://gerrit.cloudera.org:8080/20651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7721953869452197f537b161bd6c6b095cc7e75f
Gerrit-Change-Number: 20651
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com>

Reply via email to