Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20651 )
Change subject: KUDU-3522 Fail early when encryption init fails ...................................................................... KUDU-3522 Fail early when encryption init fails If encryption is enabled using --encrypt_data_at_rest, but the file system was formatted without encryption enabled, Kudu would be unable to bootstrap tablets as the encryption headers are missing, however, it would still start happily without being able to host any tablets. In some cases, for example when attempting to rebalance a cluster which contain such "zombie" tablet servers, it can cause some cryptic error message such as this: Failed to initialize encryption: error:0607B083:digital envelope routines:EVP_CipherInit_ex:no cipher set This commit adds a check to the FS manager to disallow starting up with encryption enabled and existing instance files without server keys to address this issue as it's better to fail early in this case. It also adds a regression test to verify it works as expected. Change-Id: I7721953869452197f537b161bd6c6b095cc7e75f Reviewed-on: http://gerrit.cloudera.org:8080/20651 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <ale...@apache.org> --- M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7721953869452197f537b161bd6c6b095cc7e75f Gerrit-Change-Number: 20651 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com>
