Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 )
Change subject: Fix a unit test in aarch64 system ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@363 PS9, Line 363: // TODO(abukor): If this is 1024, this becomes full when writing the first : // block because of alignments. If it is over 4k, it fails with encryption : // disabled due to having only 5 containers instead of 10. Investigate this. The modification is related to the comments above, you can update it as well. http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@368 PS9, Line 368: size nit: sizes http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: 2 * Why it is 2, not 3 or 4? It would be great to add some comments, thanks! http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: GetParam() ? It would be great to mention the encryption header size, I guess it's the reason of setting different FLAGS_log_container_max_size, is it? -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Nov 2023 08:57:57 +0000 Gerrit-HasComments: Yes
