Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 )
Change subject: Fix a unit test in aarch64 system ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@370 PS10, Line 370: // For example, usually on x86 architecture it is 4k but on aarch64 some : // linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k : // block size kernel. > I think in this context it's not relevant what's the default block size in Yes, you are right. Function GetBlockSize() is decided by 'st_blksize'. And Kudu uses st_blksize to decide the IO block size. But I have some confusions about the block size. In my aarch64 system, st_blksize is 65536, but when I storage 64 bytes into a file, it shows the file size is 4096 bytes not 65536 bytes on disk. Could you pay some attentions to this issue: https://issues.apache.org/jira/browse/KUDU-3523. Thanks. http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@376 PS10, Line 376: 1024 > Given the comment above, I'd think might be set to fs_block_size instead of Set FLAGS_log_container_max_size fs_block_size or 1024 is both OK when encryption is enabled. Because fs_block_size or 1024 bytes both occupy one block on disk. -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Nov 2023 03:37:25 +0000 Gerrit-HasComments: Yes
