Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 )
Change subject: [compaction/flush] Cleanup of compaction and flush code paths ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/tablet.cc@2001 PS4, Line 2001: size_t Tablet::GetAllDeltasSizeOnDisk(const RowSetsInCompactionOrFlush &input) { Just curious, is there a use case where it would be useful to have separate methods for calculating the on-disk size for the redo_deltas and the undo_deltas separately? http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/tablet.cc@2023 PS4, Line 2023: size_t deltas_on_disk_size = 0; Is 'deltas_on_disk_size' going to be used in a follow up patch? IIUC it's set here, but not used elsewhere in the code. -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 21:52:25 +0000 Gerrit-HasComments: Yes
