Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 )
Change subject: [compaction/flush] Cleanup of compaction and flush code paths ...................................................................... Patch Set 4: (3 comments) Thanks for the review. http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h File src/kudu/tablet/compaction.h: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h@118 PS4, Line 118: const > nit: alignment Done http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h@121 PS4, Line 121: compaction > Also update the comments. Done http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.cc@1388 PS4, Line 1388: // Following method processes the compaction input by reading input rows in : // blocks and for each row inside the block: : // - Apply all REDO mutations collected for the row at hand : // - Generate corresponding UNDO deltas for applied mutations : // - For a row with 'ghost' entries, merge their histories of mutations : // - Remove any ancient UNDO mutations, as those are not applicable anymore : // - Append UNDO and REDO deltas to DiskRowSetWriter output : // - Append fully or partially (resized) processed rowblock to DRS writer output > Instead of writing comments at the head of function, I'd prefer to palce th Most of the code below has these comments. I have added one liner comments to the remaining major items below. It is good to have a summary (at top) of what this method does. That way it becomes easy to skim through the logic of this method quickly. -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:50:58 +0000 Gerrit-HasComments: Yes
