Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20725

to look at the new patch set (#4).

Change subject: KUDU-3527 Fix block manager test on 64k filesystems
......................................................................

KUDU-3527 Fix block manager test on 64k filesystems

BlockManagerTest.TestMetadataOkayDespiteFailure might fail on systems
where fs_block_size=64k.
Currently  tablets fail to load if one metadata is missing but there
is still a non-empty ".data" file. If FLAGS_env_inject_eio is not zero,
then there is a chanche that, when we delete the container file,
we only delete the ".meta", but leave the ".data" file.
In the current test on systems with fs_block_size=4k deletion never
occurs.
Changing to kNumAppends=64 will cause the test to randomly fail on x86
systems too, altough only with a 2-3% chanche (at least on my ubuntu20
machine).

The real solution would be to make tablet loading more error resistant,
there are plans for that, but it is not trivial:
https://issues.apache.org/jira/browse/KUDU-3458

The sort term solution is to make sure no container becomes full.

Change-Id: I7e325bde502b7d7f39dd17fa84cb7eb42a3d7c20
---
M src/kudu/fs/block_manager-test.cc
1 file changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/20725/4
--
To view, visit http://gerrit.cloudera.org:8080/20725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e325bde502b7d7f39dd17fa84cb7eb42a3d7c20
Gerrit-Change-Number: 20725
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to