Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 )
Change subject: KUDU-3527 Fix block manager test on 64k filesystems ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@7 PS5, Line 7: Fix block manager test on 64k filesystems Have you looked at this patch -> https://gerrit.cloudera.org/#/c/20680/ Take a look if you haven't, to see if there is any correlation. http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@13 PS5, Line 13: chanche chance http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@18 PS5, Line 18: altough although http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@18 PS5, Line 18: chanche chance http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@25 PS5, Line 25: sort short http://gerrit.cloudera.org:8080/#/c/20725/5/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20725/5/src/kudu/fs/block_manager-test.cc@936 PS5, Line 936: FLAGS_log_container_max_size = 512 I am not quite clear on why we need to increase container max size. It would be great if you could add some more details here. -- To view, visit http://gerrit.cloudera.org:8080/20725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e325bde502b7d7f39dd17fa84cb7eb42a3d7c20 Gerrit-Change-Number: 20725 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 12:29:33 +0000 Gerrit-HasComments: Yes