Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 )
Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20792/1/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20792/1/src/kudu/tablet/compaction.cc@479 PS1, Line 479: if (0 == ret) { : // Log the timestamp value, invalid value could mean potential corruption. : LOG(INFO) << Substitute("Both DELETE REDO mutations are stamped with same timestamp i.e. $0", : left_last->timestamp().ToString()); : } I guess it's not safe to continue from here having the invariant broken. With that, I'd think of the following: CHECK(ret != 0) << Substitute("different DELETE REDO mutations must not have same timestamp $0", left_last->timestamp().ToString()); BTW, do you want to output more information here, maybe the whole left and right branches' history of mutations? -- To view, visit http://gerrit.cloudera.org:8080/20792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I508254a83046818b81db4577bf07265b46a13c9a Gerrit-Change-Number: 20792 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Dec 2023 19:48:49 +0000 Gerrit-HasComments: Yes
