Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 )
Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20792/2/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20792/2/src/kudu/tablet/compaction.cc@483 PS2, Line 483: left_last->timestamp().ToString(), > Printing the timestamp is redundant. I checked StringifyMutationList output Good catch about redo_head! Printing timestamp was kind of deliberate to make it easy to spot the conflicting timestamp. Removed, anyway it should be easy to spot it. -- To view, visit http://gerrit.cloudera.org:8080/20792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I508254a83046818b81db4577bf07265b46a13c9a Gerrit-Change-Number: 20792 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Dec 2023 19:35:10 +0000 Gerrit-HasComments: Yes
