Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20787
to look at the new patch set (#6).
Change subject: [compaction] Add memory estimation unit test
......................................................................
[compaction] Add memory estimation unit test
FLAGS_rowset_compaction_memory_estimate_enabled was always set to
false during testing, so this part of the code was not executed in
testing environment. Since it wasn't executed, it needed some changes
so that it can run in testing,too:
1. MockDiskRowSet can not be downcasted to DiskRowSet, so a new function
called OnDiskDeltaSize was introduced into RowSet, so now downcasting is
not needed anymore and the OnDiskDeltaSize function is used instead.
2. metrics_ is not set up during testing, so it is skipped if it is not
initialized.
Change-Id: I5397c7e7bf29942a610b0b8203b6918811c49bbb
---
M src/kudu/tablet/compaction_policy-test.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mock-rowsets.h
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
8 files changed, 87 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/20787/6
--
To view, visit http://gerrit.cloudera.org:8080/20787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5397c7e7bf29942a610b0b8203b6918811c49bbb
Gerrit-Change-Number: 20787
Gerrit-PatchSet: 6
Gerrit-Owner: Ádám Bakai <aba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com>
