Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 )
Change subject: [compaction] Add memory estimation unit test ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20787/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20787/6//COMMIT_MSG@9 PS6, Line 9: FLAGS_rowset_compaction_memory_estimate_enabled was always set to : false during testing, so this part of the code was not executed in : testing environment > Indeed! I recall that when I was working on 1556a353e, I verified the code Hi Alexey, Adam, Just a side note - while the test added here does go through the memory budgeting estimation code added in 1556a353e, it relies on MockDiskRowSet and its size that is set by the test to ensure it is more than the budget. That does the trick and test out the budgeting checks with mock rowsets. Additionally, I have added unit tests to test out the same budgeting checks with actual workload that generates deltas with specified memory requirements for compaction. You can check it out here: https://gerrit.cloudera.org/#/c/20816/ -- To view, visit http://gerrit.cloudera.org:8080/20787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5397c7e7bf29942a610b0b8203b6918811c49bbb Gerrit-Change-Number: 20787 Gerrit-PatchSet: 6 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jan 2024 06:23:50 +0000 Gerrit-HasComments: Yes
