Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 )
Change subject: [compaction/flush] Cleanup of compaction and flush code paths ...................................................................... Patch Set 7: (3 comments) > (1 comment) > > > > Patch Set 7: Code-Review+1 > > > > > > LGTM, looks like there's some overlap between this patch and > > Adam's patch: https://gerrit.cloudera.org/c/20787/. > > > > It doesn't show a merge conflict, so it should be safe to merge, > > right? > > IIUC, there isn't a conflict, but it's some logical duplication -- > if merging both patches, it's would be necessary to converge on the > way to get estimation for the total size of UNDO/REDO deltas. To > me, Adam's approach looks a bit cleaner. > > But indeed: I think that converging on that could be done in a > separate follow-up changelist. Agreed. At this point, my patch seems closer to being merged. I am ok with sending a follow-up patch (after Adam's patch is merged) that uses Adam's method instead. http://gerrit.cloudera.org:8080/#/c/20720/7/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20720/7/src/kudu/tablet/compaction.cc@1468 PS7, Line 1468: // - Append UNDO deltas to DiskRowSetWriter output > nit for here and below: please keep the style of the comments consistent th Done http://gerrit.cloudera.org:8080/#/c/20720/5/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/20720/5/src/kudu/tablet/tablet.h@706 PS5, Line 706: & > nit: per current style guideline, the ampersand should stick to the type, n Done http://gerrit.cloudera.org:8080/#/c/20720/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/20720/7/src/kudu/tablet/tablet.cc@2004 PS7, Line 2004: DiskRowSetSpace drss; > If my patch gets merged, OnDiskDeltaSize can be used instead of this soluti Yes, fine by me. -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 7 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 11:59:17 +0000 Gerrit-HasComments: Yes
