Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 )
Change subject: [compaction/flush] Cleanup of compaction and flush code paths ...................................................................... Patch Set 7: (1 comment) > > Patch Set 7: Code-Review+1 > > > > LGTM, looks like there's some overlap between this patch and > Adam's patch: https://gerrit.cloudera.org/c/20787/. > > It doesn't show a merge conflict, so it should be safe to merge, > right? IIUC, there isn't a conflict, but it's some logical duplication -- if merging both patches, it's would be necessary to converge on the way to get estimation for the total size of UNDO/REDO deltas. To me, Adam's approach looks a bit cleaner. But indeed: I think that converging on that could be done in a separate follow-up changelist. http://gerrit.cloudera.org:8080/#/c/20720/5/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/20720/5/src/kudu/tablet/tablet.h@706 PS5, Line 706: & nit: per current style guideline, the ampersand should stick to the type, not the parameter/variable -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 7 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 17:52:10 +0000 Gerrit-HasComments: Yes
