Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 )
Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... Patch Set 4: > Do you have any real problem running kudu? > For me Kudu seems to kind of handle f_bsize != st_blksize kind of. > So it can run an such a disk (maybe not by optimal performance). > So backward compatibility is an issue, since there can be a Kudu > running on such a system. which means only this flag solution can > work. > Also some of these consistently tests fail on x86_64 to if you > make an ifs disk with 1k blocks. > > I think using f_bsize instead of st_blksize might actually be the > better way on 64k rhel if the disk is 4k. > > So I support the addition of these flags. > However I think we should extend/fix the tests to test both false > and true values of the flag. *xfs disk -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jan 2024 14:58:00 +0000 Gerrit-HasComments: No
